search

pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.5k stars 1.8k forks source link

[Bug] Abilities that change move type seem to change the Type icons in the UI #3996

Open star-krieg opened 2 months ago

star-krieg commented 2 months ago

Describe the bug

Abilities that change move type (Normalize, Refrigerate, etc.) also change the move type icons in the UI. I don't think this is intentional because this happened before in a different bug fix PR (https://github.com/pagefaultgames/pokerogue/pull/1440#issuecomment-2145857208) but it was fixed before it was merged.

Session export file

Session data with a Normalize fusion Smeargle sessionData4_starkrieg.txt

User data export file

No response

Expected behavior

Expected to see the original move type icons for the moves instead of the type-changed icons.

Screenshots / Videos

Here are some screenshots:

Amaura with Refrigerate Refrigerate_IceIcons Smeargle fused to a Normalize Delcatty NormalSmeargle

What OS did you observe the bug on?

Mac/OSX

If other please specify

No response

Which browser do you use?

Chrome

If other please specify

No response

Additional context

No response

innerthunder commented 2 months ago

I intentionally changed this in this PR, which borrowed from another PR that made the same changes.

I would say this isn't a bug, but I suppose this could use more input from other devs.