pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.51k stars 1.81k forks source link

[Bug] Random Trainer Shininess Can End up on the Incorrect Pokémon #4377

Open Snailman11 opened 1 month ago

Snailman11 commented 1 month ago

Describe the bug

-If a Trainer with a set team randomly has a shiny, the shininess is saved for that slot. If the Trainer is encountered again with changed party slots, then the new Pokémon in that slot will be shiny instead of the previous one.

https://github.com/pagefaultgames/pokerogue/blob/7ea608fb8aaa0769e6a9799cbb3b1c45d3dc9474/src/field/pokemon.ts#L3954C1-L4001C8

Seems to consider only consider slot

Link to Discord

Session export file

No response

User data export file

No response

Expected behavior

The correct Pokémon, if it exists on the player's second encounter with that trainer should be shiny, rather than a different Pokémon.

Screenshots / Videos

No response

What OS did you observe the bug on?

Other

If other please specify

No response

Which browser do you use?

Other

If other please specify

No response

Additional context

No response

Snailman11 commented 1 month ago

Where Gender is Slot dependent, and Gmax Eevee changes slots and changes genders https://discord.com/channels/1125469663833370665/1293381515937579008