pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.54k stars 1.82k forks source link

[Bug] Fixed-damage moves dealing critical hits #4499

Open PigeonBar opened 2 months ago

PigeonBar commented 2 months ago

Describe the bug

(First reported at https://discord.com/channels/1125469663833370665/1125894949020381285/1289739808125751307)

Fixed-damage moves, such as Super Fang and Night Shade, can score critical hits. It appears that this bug is purely visual and does not cause the moves to deal extra damage.

Reproduction

To reproduce this bug easily, use overrides to give Farfetch'd a leek, a scope lens, and some fixed-damage moves.

Expected behavior

According to https://bulbapedia.bulbagarden.net/wiki/Category:Moves_that_deal_direct_damage, fixed-damage moves should not be able to score critical hits.

Screenshots / Videos

https://github.com/user-attachments/assets/edfa3eb1-2e2f-41f1-b6b4-59295ec0b3ed

Session export file

No response

User data export file

No response

Additional context

No response

Snailman11 commented 1 month ago

Night Shade from a Discord Post https://discord.com/channels/1125469663833370665/1299842758822858833