search

pagefront / ember-pagefront

Official Pagefront Ember Addon
MIT License
13 stars 7 forks source link

Consider namespacing CLI commands #15

Open kpfefferle opened 8 years ago

kpfefferle commented 8 years ago

Has PageFront considered namespacing the cli commands that it is introducing? Instead of using ember claim and ember login, maybe the commands could be ember pagefront:claim and ember pagefront:login? The current approach certainly makes the commands feel like an integral part of ember-cli, but that may have drawbacks down the line.

I can see two benefits to moving to namespaced commands:

  1. As PageFront inevitably adds more CLI commands, this would avoid naming collisions with other addons or new ember-cli core commands.
  2. Every namespaced command reinforces the PageFront brand even though deploy is ember deploy, much like Heroku CLI commands do (heroku config..., heroku run..., etc) though Heroku's deploy flow is simply a git push.
jasonkriss commented 8 years ago

Thanks a lot @kpfefferle! This is definitely something we want to consider doing. Gonna keep this open while we put some more thought into it.