pagekite / libpagekite

A high performance PageKite implementation in C
https://pagekite.net/wiki/Floss/LibPageKite/
86 stars 37 forks source link

cli is unhelpful when invalid arguments are specified #71

Open karlp opened 4 years ago

karlp commented 4 years ago

Version: 0.91.191211

When "http" is given as the protocol twice, it fails to start, but doesn't really say why. At least in this instance, it needed to change from http to "http-8083" but that's non-obvious

root@eg-03B679:/# pagekitec 80 http blah.pagekite.me 0 averybadpassword 8083 ht
tp blah.pagekite.me 0 averybadpassword
t=2019-12-11 15:00:13.675; ts=5df1047d; tid=77f2ae84; ll=0; msg=Initialized pagekitec manager v0.91.190530C/0.91.190530C (using 495121 bytes)
t=2019-12-11 15:00:14.178; ts=5df1047e; tid=77f2ae84; ll=1; msg=pkm_lookup_and_add_frontend: getaddrinfo(fe6_091c.b5p.us, 443) failed:
t=2019-12-11 15:00:14.179; ts=5df1047e; tid=77f2ae84; ll=2; msg=Starting manager in new thread
t=2019-12-11 15:00:14.181; ts=5df1047e; tid=77b28d74; ll=3; msg=Tick!  [repeating=yes, next=16, tunnels=0, v=0.91.190530C]
t=2019-12-11 15:00:15.208; ts=5df1047f; tid=77ae2d74; ll=4; msg=pkm_lookup_and_add_frontend: getaddrinfo(fe6_091c.b5p.us, 443) failed:
t=2019-12-11 15:00:15.210; ts=5df1047f; tid=77ae2d74; ll=5; msg=Connecting to [185.112.146.199]:443 (session=new, is fast, in DNS)
t=2019-12-11 15:00:15.255; ts=5df1047f; tid=77ae2d74; ll=6; msg=5: TLSv1.2 connection established: ECDHE-RSA-CHACHA20-POLY1305 TLSv1.2 Kx=ECDH Au=RSA Enc=CHACHA20/POLY1305(256) Mac=AEAD 
t=2019-12-11 15:00:15.328; ts=5df1047f; tid=77ae2d74; ll=7; msg=Connecting to [185.112.146.199]:443 (session=5df1047f:c44b8ca05403fe93969e1ef75c7f541ba0e6eda1, is fast, in DNS)
t=2019-12-11 15:00:15.371; ts=5df1047f; tid=77ae2d74; ll=8; msg=5: TLSv1.2 connection established: ECDHE-RSA-CHACHA20-POLY1305 TLSv1.2 Kx=ECDH Au=RSA Enc=CHACHA20/POLY1305(256) Mac=AEAD 
t=2019-12-11 15:00:15.561; ts=5df1047f; tid=77ae2d74; ll=9; msg=Connect failed: -1
t=2019-12-11 15:00:15.562; ts=5df1047f; tid=77ae2d74; ll=a; msg=pkmanager.c: Rejected by front-end
BjarniRunar commented 3 years ago

This is a little tricky to fix, but thank you for reporting it. We should be able to detect if the user is requesting two indistinguishable kites and bail before ever talking to the front-end.