search

pageldev / libOpenDRIVE

Small, lightweight C++ library for handling OpenDRIVE files
Apache License 2.0
368 stars 134 forks source link

Feature: add signal mesh creation #84

Closed michikommader closed 10 months ago

michikommader commented 10 months ago

We extend the current signal implementation with creation of signal meshes. Additionally, these signal meshes are added to the OpenDriveMap and also parsed in test.cpp.

This feature contributes to #21.

michikommader commented 10 months ago

I would further like to suggest renaming of the class Signal to RoadSignal in order to align it with RoadObject because both <signals> and <objects> are direct XML child nodes of a <road>. Sure, this is optional, but it might improve code structure. What do you think @grepthat?

pageldev commented 10 months ago

Looks really good! Thanks for providing this. I merged this into the viewer and verified that the signals look good. You can ahead and change Signal to RoadSignal.

michikommader commented 10 months ago

I would appreciate if you also create a new version/release tag after merging this signal feature into master.