search

pagemachine / typo3-opcache-control

PHP Opcache management for TYPO3
GNU General Public License v3.0
5 stars 2 forks source link

#19 fix appended site path beeing ignored #20

Open tgaertner opened 1 year ago

mbrodala commented 1 year ago

Nice catch, we did basically drop the site base path (general and languages) here. :+1:

mbrodala commented 1 year ago

Are you able to adjust the CLI tests to haven an error which your change fixes? I tried myself with a custom site base URL but that didn't work reliably ...

tgaertner commented 1 year ago

A little readme in the project how to setup the test environment would be helpful. I started the docker compose environment and run into a php version mismatch.

mbrodala commented 1 year ago

Indeed, added now: https://github.com/pagemachine/typo3-opcache-control/commit/e23379a48c7c0f8d638237e3fbf3b989ff4f2c25

tgaertner commented 1 year ago

Sadly I was still not able to execute the tests locally . Build is crashing because phpstan is complaining.

Running "docker compose run --rm app composer test" crashes with an connection error. Sorry I'm not too deep into docker compose.

BTW. on my Linux host the command has to be "docker compose" (without the minus)

mbrodala commented 1 year ago

You can use both the standalone (Python) as well as embedded (Go) version of Docker Compose. Which actually works fine everywhere, see e.g. the CI here. :thinking: