pages-themes / architect

Architect is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/architect/
Creative Commons Zero v1.0 Universal
313 stars 799 forks source link

_sass/jekyll-theme-architect.scss: HEADER H1, H2 WIDTH should be incremented by 150px #28

Closed YouDirk closed 5 years ago

YouDirk commented 5 years ago

Hi,

it seems that the header h1, header h2 { width: ... } in _sass/jekyll-theme-architect.scss should be incremented by 150px. These line wrappings are to close. Currently I am overrriding it in my project and it looks like this:

https://github.com/YouDirk/youdirk_numeric_io/blob/master/docs/assets/css/style.scss

@import "{{ site.theme }}";

/* Overrides
 * https://github.com/pages-themes/architect/blob/master/_sass/jekyll-theme-architect.scss
 */

/* Titles not width enough +150px (seems to be a bug in original
 * version)
 */
header h1, header h2 {
  width: 690px;
}

/* Tablet Portrait size to standard 960 (devices and browsers) */
@media only screen and (min-width: 768px) and (max-width: 959px) {

  /* Titles not width enough +150px (seems to be a bug in original
   * version)
   */
  header h1, header h2 {
    width: 490px;
  }
}

/* All Mobile Sizes (devices and browser) */
@media only screen and (max-width: 767px) {

  /* Same as overridden version  */
  header h1, header h2 {
    width: 100%;
  }
}

I think it should be adapted here?

cu and greets, Dirk :)

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.