Blockquote has too great a visual impact.

[SandorDosa]

While posting the results of a survey (Number list for the questions with blockquoted answers, I discovered a visual oddity in the theme.

blockquote text has similar visual impact as Header1.

After a little digging it seems that line298 is the problem.

blockquote {
  padding: 0 0 0 30px;
  margin-bottom: 20px;
  font-size: 1.6em;
  border-left: 10px solid #e9e9e9;
}

Isn't that a bit excessive for what is typically an element styled congruent with P and PRE? Also, it seems to be the only text constructor with a size in em, everything else is in px.

Here is a side-by-side composite image of the browser view within GitHub and the view after the Jekyll theme has been applied.

[benbalter]

@SandorDosa Can you explain a bit more about what you're trying to accomplish? To note, the goal is not to make the theme match the rendering of Markdown on GitHub.com.

[SandorDosa]

@benbalter Certainly, I'm trying to keep the visual appearance and weight of blockquote text similar to normal P or PRE text. To that end, I followed standard GitHub proceedure for overriding the theme and placed the following code in /assets/css/style.scss

blockquote {
  padding: 0 0 0 30px;
  margin-bottom: 20px;
  font-size: 15px;
  border-left: 10px solid #e9e9e9;
}

Note all I changed was font size (to 15px from 1.6em), and that value was taken from earlier in your theme SCSS file...

body {
  font-family: 'Helvetica Neue', Helvetica, Arial, serif;
  font-size: 15px;
  font-weight: 400;
  line-height: 1.5;
  color: #666;
  background: #fafafa url(../images/body-bg.jpg) 0 0 repeat;
}

I fear that my use of Github as example is something of a red herring. I was merely trying to show the difference between what I was expecting versus what was being rendered. In the process of writing this reply, I've been forced to reconsider my original theory that this was an aberration and that I should report it to you.

If this was actually what you designed for, then you have my apologies for the confusion. Though that leaves me with the question why your design called for blockquote to be enhanced over regular text.

[benbalter]

@SandorDosa can you provide an example of the rendered text (via Jekyll) before and after your proposed change?

[SandorDosa]

@benbalter Sure.

BEFORE: (ignore filename content -- this is an old screenshot)

AFTER: (captured at the time of writing)

The modified theme is currently being used for the survey results page which you are welcome to view in situ.

In the latter example you can see what I was trying to show, a numbered list of questions, each with sub-level of lettered lists (though for the sub-level I am indexing by hand)

[benbalter]

Oh. @SandorDosa good catch. You are correct. Would you be able to submit a pull request to implement that change in the scss here?

[SandorDosa]

@benbalter No prob, done.