pages-themes / leap-day

Leap day is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/leap-day/
Creative Commons Zero v1.0 Universal
206 stars 489 forks source link

Remove unused code #14

Closed JoeBiellik closed 6 years ago

JoeBiellik commented 6 years ago

This removes the incorrect and unused Internet Explorer conditional comment and JS.

Since the initial commit, the code has included some JS to set viewport options, behind an IE conditional comment. Unfortunately, this conditional comment is incorrectly formatted and therefore invalid.

A valid IE condtional comment must be in the form <![if !IE]>...<![endif]> or <!--[if !IE]><!-->...<!--<![endif]-->, however the code uses <!--[if !IE]>...<![endif]--> which all browsers will parse as a standard comment and ignore.

To the best of my knowledge, no browser has or will ever invoke this code, so this removes it entirely.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.