w3 validator error and warnings - Githubissues

pages-themes / leap-day

Leap day is a Jekyll theme for GitHub Pages

https://pages-themes.github.io/leap-day/

Creative Commons Zero v1.0 Universal

204 stars 484 forks source link

w3 validator error and warnings #20

Closed casperdcl closed 6 years ago

casperdcl commented 6 years ago

Source: https://validator.w3.org/nu/?doc=http%3A%2F%2Fpages-themes.github.io%2Fleap-day

https://github.com/pages-themes/leap-day/blob/6501e798cca1defbab65eb794c7085dfa0f2d8ff/_layouts/default.html#L5
- A meta element with an http-equiv attribute whose value is X-UA-Compatible must have a content attribute with the value IE=edge
https://github.com/pages-themes/leap-day/blob/6501e798cca1defbab65eb794c7085dfa0f2d8ff/_layouts/default.html#L14
- Consider avoiding viewport values that prevent users from resizing documents
<h1 id="header-1">
- Consider using the h1 element as a top-level heading only (all h1 elements are treated as top-level headings by many screen readers and other tools)
- this could be solved by allowing section h3 in the nav: https://github.com/pages-themes/leap-day/blob/6501e798cca1defbab65eb794c7085dfa0f2d8ff/assets/js/main.js#L16

Also,

https://github.com/pages-themes/leap-day/blob/6501e798cca1defbab65eb794c7085dfa0f2d8ff/_layouts/default.html#L56
- The type attribute is unnecessary for JavaScript resources