search

pages-themes / leap-day

Leap day is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/leap-day/
Creative Commons Zero v1.0 Universal
203 stars 483 forks source link

Add way to link to another header in the page #26

Closed jennselby closed 5 years ago

jennselby commented 6 years ago

This change allows scrolling behavior for links in the main text to another header to work as they already do for nav links. Right now, it requires the developer to add a class to the link element to get this behavior, because I wasn't sure that you'd want it to happen automatically for any link starting with '#' outside of nav.

Added an example of this feature to index.md.

Note that the automated tests do not pass, but they did not pass for me on master. The issue seems to be coming from an 'auto' value for padding, which the W3C validator does not like (I'm guessing that's a new addition to their tests).

welcome[bot] commented 6 years ago

Welcome! Congrats on your first pull request to The Leap Day Theme. If you haven't already, please be sure to check out the contributing guidelines.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.