search

pages-themes / leap-day

Leap day is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/leap-day/
Creative Commons Zero v1.0 Universal
203 stars 483 forks source link

Make the `nav` menu scrollable #63

Open ParadoxV5 opened 2 years ago

ParadoxV5 commented 2 years ago

When the <nav> menu has many items (is long) or on short-height windows or screens, the <nav> simply overflows the window with the overflown items cut-off and inaccessible. This quick-fix proposal constraints the <nav> at the bottom and enables scrolling for overflow behaviour.

Although, browsers’ – at least Chrome – scrollbars look thicc and out of place.

I discovered this oversight while trying to fix #48/#62. This can be an initiating step, as the next would be making the bottom retract to make room for the <footer> (which has non-constant height, and I am not aware of how to respond to that).

welcome[bot] commented 2 years ago

Welcome! Congrats on your first pull request to the Leap Day theme. If you haven't already, please be sure to check out the contributing guidelines.

markcmiller86 commented 2 years ago

@ParadoxV5 thanks for this! It works for me and I really needed it :clap: