Make section scrolling work with modified CSS

pages-themes / leap-day

Leap day is a Jekyll theme for GitHub Pages

https://pages-themes.github.io/leap-day/

Creative Commons Zero v1.0 Universal

203 stars 483 forks source link

Make section scrolling work with modified CSS #75

Open mattalbright opened 3 months ago

mattalbright commented 3 months ago

190px is hardcoded in the Javascript, whereas a user of this theme can easily override the size of the header and banner, and hence the location of the top of the main section. This change makes the scrollTop location when clicking a nav link always be correct, instead of assuming the main section is always 190px from the top.

welcome[bot] commented 3 months ago

Welcome! Congrats on your first pull request to the Leap Day theme. If you haven't already, please be sure to check out the contributing guidelines.