search

pages-themes / midnight

Midnight is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/midnight/
Creative Commons Zero v1.0 Universal
305 stars 566 forks source link

Wrap <li> in <ul>, not directly in <nav>. #32

Closed olifre closed 3 years ago

olifre commented 3 years ago

<li> must now be used in <nav>, this yields a HTML validator violation otherwise. So wrap it in <ul> and remove any effects of the <ul>.

parkr commented 3 years ago

Thank you so much!

welcome[bot] commented 3 years ago

Congrats on getting your first pull request to the Midnight theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! :tada:

If you're interested in tackling another bug or feature, take a look at the open issues, especially those labeled help wanted.

olifre commented 3 years ago

Thank you so much!

Thank you for coming back and checking the PRs, it's good to see the project is still alive :+1: .