pages-themes / midnight

Midnight is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/midnight/
Creative Commons Zero v1.0 Universal
305 stars 566 forks source link

Suddenly top menu bars are gone and replaced with blue icons? #42

Open SkyperTHC opened 2 years ago

SkyperTHC commented 2 years ago

Hello,

I did not do anything for 8 month on my webpage and suddenly the pages (hosted on github) show a 'blue navigation bar' at the stop instead of the midnight navigation bar:

Screenshot 2021-11-15 at 13 19 55

It works fine on my jekyll (127.0.0.1:4000):

Screenshot 2021-11-15 at 18 38 55

Umm. How to fix this? I'm not a jekyll expert at all.

SkyperTHC commented 2 years ago

i found the problem. Seems like the midnight theme had a major update. The version of the theme expected by github was not the version that I used to originally created the webpage. I thus re-installed the entire webpages and merged in all my changes into the latest version of the theme.

Thereafter I nailed it down (out of curiosity) and found that the culprit was in _layouts.default.html. The midnight that github expected needed {% include head-custom.html %} statement whereas the version that I was using did not have that statement.

I'm surprised that by github moving to a new midnight theme release that it would break existing pages...Is there a way to prevent this happening in the future? E.g. mark it as 'static' or so?

Jiab77 commented 2 years ago

If I may add something, it seems to be like a missing <ul></ul> surrounding as said elsewhere. You can then decide to change your current CSS chain:

image

To: #header nav li.*

It should work but it will break the web standards... or you can restore the <ul></ul> tags that has been dropped in this commit.

Sorry, if I bothered you, just wanted to be helpful.