search

pages-themes / slate

Slate is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/slate/
Creative Commons Zero v1.0 Universal
301 stars 975 forks source link

_sass/jekyll-theme-slate.scss: Remove bold style of hyperlinks on hover. #20

Closed lhmouse closed 6 years ago

lhmouse commented 6 years ago

This fixes a text flickering issue.

It was introduced in ef69e5aa955c115eeaa2b670d5c74ee79a4d89fc, whose commit message said 'fixing up color contrast issues'. On some browsers, bold text is rendered longer and takes up more space than normal text. Hence making hyperlinks bold on hover pushes everything after a link afterwards.

Discussion: https://github.com/pages-themes/slate/commit/ef69e5aa955c115eeaa2b670d5c74ee79a4d89fc#diff-0c98b278830c5f885e539016b209473cR118 Signed-off-by: Liu Hao lh_mouse@126.com

lhmouse commented 6 years ago

@mgifford :laughing:

lhmouse commented 6 years ago

This is a duplicate of #17.

benbalter commented 6 years ago

If you are making visual changes, include a screenshot of what the affected element looks like, both before and after.

lhmouse commented 6 years ago

@benbalter As you wish. The following three screenshots are taken of https://lhmouse.github.io/:

A hyperlink having normal weight.

1

A hyperlink that becomes bold on hover. Note the word previews is pushed to the next line.

2

A hyperlink that does not become bold on hover i.e. with this patch applied. (I lightened it a little, which was not included in this PR.)

3

welcome[bot] commented 6 years ago

Congrats on getting your first pull request to The Slate Theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! :tada:

If you're interested in tackling another bug or feature, take a look at the open issues, especially those labeled help wanted.

lhmouse commented 6 years ago

Thank you. :joy: