search

pages-themes / slate

Slate is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/slate/
Creative Commons Zero v1.0 Universal
303 stars 981 forks source link

Double colon ::pseudo is highlighted as error #28

Closed cliffasaurus closed 5 years ago

cliffasaurus commented 5 years ago

Syntax highlighting does not seem to recognize double colon pseudo elements. I read that jekyll uses rouge and saw that this was an issue before at rouge https://github.com/jneen/rouge/pull/212 and this was closed there. Not sure if this is the correct place to submit this issue. image

ahuglajbclajep commented 5 years ago

GitHub Pages is generated in the same environment as pages-gem. This problem seems to be related to the following issue. https://github.com/github/pages-gem/issues/601

In fact, GitHub Pages seems to be using rouge 2.2.1. https://pages.github.com/versions/

cliffasaurus commented 5 years ago

The issue seems to have been fixed in v1.7.5 though. (Which has been long before 2.2.1) https://github.com/jneen/rouge/pull/212#issuecomment-68061745

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.