search

pages-themes / slate

Slate is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/slate/
Creative Commons Zero v1.0 Universal
301 stars 975 forks source link

Make usage of <code> in headers *not* ugly #34

Closed toughengineer closed 4 years ago

toughengineer commented 4 years ago

0.875 is 14/16 (16px being the default font size specified in the rule for \<body>). This way usage of \<code> elements will not be ugly since the font size will be relatively scaled (e.g. 28px instead of 14px for \<h2> with default size 32px).

Example of ugliness: https://toughengineer.github.io/talks/C++%20Siberia%202020/

welcome[bot] commented 4 years ago

Welcome! Congrats on your first pull request to The Slate Theme. If you haven't already, please be sure to check out the contributing guidelines.

toughengineer commented 4 years ago

before: image

after (code element text is of (relatively) normal size): image

welcome[bot] commented 4 years ago

Congrats on getting your first pull request to The Slate Theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! :tada:

If you're interested in tackling another bug or feature, take a look at the open issues, especially those labeled help wanted.

abdullahkavakli commented 3 years ago

The problem continues.

toughengineer commented 3 years ago

@abdullahkavakli, it is not fixed on GitHub Pages because the new version in this repo is not deployed to GitHub pages instance or something like that. Maybe we can ask @benbalter to push/deliver the new version from this repo to GitHub pages. That'd be great.

abdullahkavakli commented 3 years ago

@toughengineer didn't benbalter merged this commit into pages-themes:master ? I couldn't understand. Can u explain more please?

toughengineer commented 3 years ago

@abdullahkavakli, my understanding is that the change is indeed in the master branch, but the code with the change is not yet delivered to GitHub pages itself, i.e. it seems that repos in pages-themes project are separate from what actual GitHub pages use, and changes from repos are not automatically delivered to GitHub pages.

abdullahkavakli commented 3 years ago

I got now what u mean. Can i ask another question? My commits can't pass travis test. Like this: https://github.com/pages-themes/slate/pull/58 Do u know why?

toughengineer commented 3 years ago

@abdullahkavakli, no idea.