search

pages-themes / slate

Slate is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/slate/
Creative Commons Zero v1.0 Universal
301 stars 975 forks source link

Looks like wrong width of img #4

Closed metelkin closed 6 years ago

metelkin commented 7 years ago

For mobile divices big figures spoile the view. I suppose the missprint is here: _sass/jekyll-theme-slate.scss

img{ ... max-width: 739px; / max-width: 100% ??? / ... }

Edditoria commented 7 years ago

Same problem here.

The push request #3 was merged, and suppose the scss style is fixed in Github. But I didn't notice until you raise this issue (Thanks!)

I think the problem still exists because the gem is not update yet?

No choice but a quick fix can solve it. Please add the following styles to style.scss

// Temp Fix for Slate theme gem for Github Pages

@media screen and (max-width: 992px) {
  img {
    max-width: 100%;
  }
}

I have created the repo for quick test: Repo | Pages preview

Please see the file style.scss for your reference. The code is exactly the same in the PR. I did this in every Pages anyway.

Happy coding!

sorry for bad English

Romainpetit commented 7 years ago

I think this has been solved with the GEM version bump https://github.com/pages-themes/slate/commit/8a052c4a3a9fc943cc9c32d4e705cf21a3258cae

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.