pages-themes / slate

Slate is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/slate/
Creative Commons Zero v1.0 Universal
301 stars 975 forks source link

Superscript/subscript tags broken by CSS #40

Open nic-hartley opened 4 years ago

nic-hartley commented 4 years ago

I wanted to include superscript (<sup></sup>) in some text. The tag itself carries through, as expected, but the Slate theme includes this CSS reset (removed the other tags it affects, which AFAICT is all of them):

sup {
    margin: 0;
    padding: 0;
    border: 0;
    font: inherit;
        font-weight: inherit;
        font-size: inherit;
    vertical-align: baseline;
}

There's no corresponding re-setup for sup, so it ends up just looking like normal text.

One fix would be to add this to the bottom of the stylesheet:

sup {
    font-size: 65%;
    vertical-align: super;
    font-weight: bold;
}

...but of course that might need tweaking to fit better in the theme. I dunno, I'm not an artist. I just want my footnotes.

Another would be to remove sub from the reset, which would apply the browser-default styling.

nic-hartley commented 4 years ago

After a quick glance, it appears sub will be broken in the same way. It'd be as simple a fix -- sub { ... vertical-align: sub; ... } instead of sup/super, but otherwise identical (with the same alternative option of just removing sub from the reset).

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

nic-hartley commented 4 years ago

This is still an issue, as far as I know. It would be nice to get it fixed so I can use superscript on Slate.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

nic-hartley commented 4 years ago

Yeah, I've given up on this issue and the theme itself. Might submit a PR for Hacktoberfest, even though I'm now rolling my own.

snownontrace commented 3 years ago

Thanks @nic-hartley -- your suggestions fixed my headache around superscripts!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

nic-hartley commented 2 years ago

sigh

Disappointing to see how completely GitHub ignores issues which are trivially fixed, and it makes me wonder what other issues are being casually ignored.