search

pages-themes / slate

Slate is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/slate/
Creative Commons Zero v1.0 Universal
303 stars 982 forks source link

Travis always gives error #60

Open abdullahkavakli opened 3 years ago

abdullahkavakli commented 3 years ago

Like even here https://github.com/pages-themes/slate/pull/59

rdipardo commented 3 years ago

The problem is rubocop: https://travis-ci.org/github/pages-themes/slate/builds/765322596#L468

Just edit the .rubocop.yml file as shown here: #54

abdullahkavakli commented 3 years ago

Thank you for your answer. It worked for my 2 requests: https://github.com/pages-themes/slate/pull/58 and https://github.com/pages-themes/slate/pull/57. But it din't here: https://github.com/pages-themes/slate/pull/59. Can u explain why?

rdipardo commented 3 years ago

No problem!

59 failed because your markup used an illegal font-size value.

The CSS specification expects real numbers to be in North American decimal style, so change , to . in the style-sheet:

diff --git a/_sass/jekyll-theme-slate.scss b/_sass/jekyll-theme-slate.scss
index 5b244dc..414d488 100644
--- a/_sass/jekyll-theme-slate.scss
+++ b/_sass/jekyll-theme-slate.scss
@@ -418,7 +418,7 @@ Small Device Styles
   }

   code, pre {
-    font-size: 0,688em;
+    font-size: 0.688em;
   }

 }
@@ -468,7 +468,7 @@ Small Device Styles
   code, pre {
     min-width: 240px;
     max-width: 320px;
-    font-size: 0,688em;
+    font-size: 0.688em;
   }

 }
abdullahkavakli commented 3 years ago

It worked. Thank you.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.