pages-themes / time-machine

Time machine is a Jekyll theme for GitHub Pages
https://pages-themes.github.io/time-machine/
Creative Commons Zero v1.0 Universal
89 stars 223 forks source link

The scrolled download icon is displayed even if `show_downloads: false` is specified. #14

Open fu-sen opened 3 years ago

fu-sen commented 3 years ago

Use this theme by setting _config.yml to:

show_downloads: false

The header disappears the download icon as expected: スクリーンショット 2020-12-06 14 59 29

But when scrolling down, the header still shows the download icon: スクリーンショット 2020-12-06 14 59 34

I referred to the template and noticed it: /_layouts/default.html:

  <div class="current-section">
    <a href="#top">Scroll to top</a>
    <a href="{{ site.github.tar_url }}" class="tar">tar</a><a href="{{ site.github.zip_url }}" class="zip">zip</a><a href="" class="code">source code</a>
    <p class="name"></p>
  </div>

There is no {% if site.show_downloads%} and {% endif%}.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.