search

pagesource / atomic-react-components

A react pattern library with collocation for generic react components equipped with recommended development ecosystem.
MIT License
19 stars 46 forks source link

Feature kd pagination #205

Closed desai-koustubh closed 4 years ago

desai-koustubh commented 4 years ago

Hi Vinod, Pagination component is right now satisfying two counts:

  1. I can use it with a table & list and any other markup
  2. Managed area with render props:

Problem:

  1. Not appropriate for table markup since buttons are also shown up as a part of table.

Q. Do I need to make Pagination a HOC? Q. I am doing something fundamentally wrong. Please give me hints or keywords to refactor (Not the logic. I will figure out the logic). Is that fine?