Integrate Prettier as a Pre-commit hook

[areai51]

Follow the steps mentioned here https://medium.com/@dovydas_s/how-much-interest-would-there-be-in-an-article-comparing-the-latest-of-angular-4-and-react-redux-accfdbea303 to setup prettier as a pre-commit

[sbmadhav]

@areai51 - The link above does not point to prettier. Was it this - https://medium.com/@brindelle/format-your-javascript-with-prettier-before-committing-177079ec356a If yes, this would work only in OSX and Linux. Will fail in Windows.

[areai51]

haha yes that that's the right link thanks

[vinaymavi]

Prettier implemented as pre-commit githook https://github.com/pagesource/fusion-components/pull/66

[vinaymavi]

@areai51 @sbmadhav can we close this issue as #66 is merged?

[sbmadhav]

@vinaymavi - I don't see the prettier configurations in development branch, can you check please?

[vinaymavi]

yes you are right @sbmadhav right now we do not have changes in master, changes got replaced by #75 PR - https://github.com/pagesource/fusion-components/pull/75/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2.

can you please suggest how we can pull back these changes?

[vinaymavi]

@sbmadhav can we close now as configuration available in development branch?

[sbmadhav]

not until it is moved to master. We need to close out the eslint issue and then I'll merge to master.

[vinaymavi]

created a PR for eslint issue - https://github.com/pagesource/fusion-components/pull/76, please check provide your comments.

[sbmadhav]

Thanks Vinay