search

pagesource / fusion-components

A collection of React Components built with Emotion.js
https://sape-fusion.herokuapp.com/
MIT License
13 stars 22 forks source link

Advocating Yarn or NPM #21

Closed sbmadhav closed 6 years ago

sbmadhav commented 6 years ago

I see that the project is using Yarn. (Yarn.lock file and a yarn lint is present as pre-commit script in package json.) But in the documentation, npm install and npm start are mentioned. So for this project are you advocating the use Yarn or Node Package Modules?

vish288 commented 6 years ago

To reach their own I guess. But we should add the line that if you use one, use it consistently. Would that work?

sbmadhav commented 6 years ago

I agree with you. We need to have your statement reflect in the code base. I would want to see the documentation being consistent with the code. Either we change the Readme.md file to use yarn syntax or use only NPM syntax in package json. For now, let's change to the npm syntax in package.json.

vish288 commented 6 years ago

This has been addressed as a part of PR #30