search

pagevamp / laravel-cloudwatch-logs

Cloud Watch Driver for Laravel as needed at pagevamp
93 stars 48 forks source link

Update composer.json #13

Closed niekvanderkooy closed 5 years ago

niekvanderkooy commented 5 years ago

Allow use of package when using Laravel 6. Tested on my fork, and everything seems to work fine.

developernaren commented 5 years ago

merged into master. Thanks for the contribution

developernaren commented 5 years ago

I get this error after this upgrade.

Problem 1

Reverting this before further investigation.

niekvanderkooy commented 5 years ago

Works fine for me... Are you sure your dependencies don't conflict somewhere else? What is the composer.json you are testing with?

Both maxbanton/cwh and laravel/framework should be fine with monolog ^1.20 (See https://github.com/maxbanton/cwh/blob/master/composer.json#L25 and https://github.com/laravel/framework/blob/6.x/composer.json#L27), while your error seems to suggest that some other dependency want ^2.0.

For reference, this is the composer.json I am using (and works fine):

{
    "type": "project",
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/niekvanderkooy/laravel-cloudwatch-logs"
        }
    ],
    "require": {
        "laravel/framework": "^6.0",
        "pagevamp/laravel-cloudwatch-logs": "dev-l6"
    }
}
developernaren commented 5 years ago

It does look like it is working with the repository url set in the composer.json file. It broke when I actually pulled this as a version in dependency. Will test when I have more time and publish. Thanks for the help.