search

paginagmbh / redmine_lightbox2

Lightbox for image attachments in Redmine
MIT License
126 stars 97 forks source link

Support for DMSF 1.6 feature "DMSF files act as attachable on issues" #53

Closed tofi86 closed 4 years ago

tofi86 commented 6 years ago

@dinya request in https://github.com/paginagmbh/redmine_lightbox2/issues/40#issuecomment-382665116:

Redmine DMSF 1.6.x allows documents attachements to issue.

Is it doable to add preview thumbnails of DMS section with preview lightbox?

tofi86 commented 6 years ago

I will add support for this feature in master branch for Redmine 3.4.

Is Redmine 3.3 support also requested?

tofi86 commented 6 years ago

@dinya: please test the current master branch with Redmine 3.4 and tell me whether it works as expected.

my tests have been successfull and I also added rel attribute so you can have a slideshow of all dmsf thumbnails (use arrow keys or icons beside the lightbox image).

dinya commented 6 years ago

Is Redmine 3.3 support also requested?

DMSF 1.6.x works with Redmine 3.4 only. So no.

Thanks. I will test current master on Monday.

dinya commented 6 years ago

@tofi86

Lightbox is works well, but:

  1. There are no thumbnails after titles like for "classic" attachments. (BTW, maybe add option in settings to either show or not thumbnails both in attachments and in DMS content.)

no_thumbnails

  1. DMS titles are not shown in a lightbox:

caption from dms

dinya commented 6 years ago

Dear @tofi86

Do you have any ideas?

tofi86 commented 6 years ago

@dinya sorry, I'm currently on parental leave with a newborn and not checking open source projects regularly.

In my case, thumbnails are shown, probably because I enabled thumbnail generation in redmine settings? I can try to add thumbnails even if this feature is turned off, like I do with the normal image attachments. will see...

About the description: you're right. I will try to take a look soon.

dinya commented 6 years ago

@tofi86

I'm currently on parental leave with a newborn

My sincere congratulations! :-)

In my case, thumbnails are shown, probably because I enabled thumbnail generation in redmine settings?

You are right: I'm enable this and it works as expected (I never used this feature before).

tofi86 commented 6 years ago

Thanks! 😊

Glad it works for you! Nevertheless, I will try to find a solution similar to the image attachements.

tofi86 commented 4 years ago

Fixed with 8e8dc02 for Redmine 3.4.

Bildschirmfoto 2019-11-02 um 19 46 55

Redmine 4 support will be available once the Redmine 3 compatible version has been released and merged to the Redmine 4 compatible version.

tofi86 commented 4 years ago

Redmine 4 support on master was added.