Syntax error in Internet Explorer 11 (IE 11) - Githubissues

paginagmbh / redmine_lightbox2

Lightbox for image attachments in Redmine

MIT License

126 stars 97 forks source link

Syntax error in Internet Explorer 11 (IE 11) #66

Closed ilpssun closed 5 years ago

ilpssun commented 5 years ago

When I use version 0.5.0 of the plugin in Redmine 4.0.4, the javascript is not working in IE 11. It says that there is a syntax error in line 90 auf lightbox.js:

grafik

The same script is working fine in Firefox and Chrome/Chromium.

I'm no javascript expert – especially not regarding the differences between IE and FF/Chrome – so no clue as to what’s wrong with the line.

tofi86 commented 5 years ago

Thanks for the report. It's fixed on branch redmine-3.4 for Redmine 3.4 and on master for Redmine 4.x

I have not yet released a new version, but will soon.

tofi86 commented 5 years ago

Sorry, the bugfix contained a bug 🙈 Now it's working and can be tested from the before mentioned branches.

tainewoo commented 5 years ago

image preview is ok now, but pdf preview still fails