[CES-4] Add new module for azure app service that can be exposed

mamu0 commented 2 months ago

List of changes

A new module called azure_app_service_exposed has been created. Functionally, it can generate an app service like the azure_app_service module, but without the networking configuration (subnets, private endpoints, etc.) and is exposed.
All README.md files for the various modules have been updated with a pre-commit.
A bug was fixed in azure_app_service related to the creation of the slot during the insertion of the node version.

Motivation and context

The reason for creating this new module was to develop a cleaner and more generic solution for azure_app_service.

Type of changes

[x] Add new resources
[x] Update configuration to existing resources
[ ] Remove existing resources

Does this introduce a change to production resources with possible user impact?

[ ] Yes, users may be impacted applying this change
[x] No

Other information

gunzip commented 2 months ago

can't we reuse the existing app service module someway? in this way it might be complex to keep things in sync between two different modules cc @Krusty93

Krusty93 commented 2 months ago

can't we reuse the existing app service module someway? in this way it might be complex to keep things in sync between two different modules cc @Krusty93

In my opinion, having two modules is much less complex rather than:

having a variable to control the creation of all underlying resources
having lot of variables with no effect when the var is_public is enabled. To me, it would create confusion

This should be a ready to go module to create a public app service without any fancy things around, to get an app up and running in a matter of minutes

pagopa / dx