pagopa / dx

Devex repository for shared tools and pipelines.
https://pagopa.github.io/dx/docs/
1 stars 0 forks source link

fix: App service staging slot name is too long #70

Closed christian-calabrese closed 1 month ago

christian-calabrese commented 1 month ago

List of changes

Set app service staging slot name to "staging"

Motivation and context

The slot staging name is automatically concatenated to the name of the app service, therefore it is not necessary to do it via terraform to prevent extremely long names

Type of changes

Does this introduce a change to production resources with possible user impact?

Other information

gunzip commented 1 month ago

isn't this a breaking chage for all of those who already use the old name? I mean in case, they're pointing to main

gunzip commented 1 month ago

is it possible that the deploy pipeline points to the old name?

christian-calabrese commented 1 month ago

isn't this a breaking chage for all of those who already use the old name? I mean in case, they're pointing to main

Yes, it is, but luckily nobody is using the module with the slot enabled yet. The only project is io-services-cms, which developers suggested the fix

Krusty93 commented 1 month ago

isn't this a breaking chage for all of those who already use the old name? I mean in case, they're pointing to main

Yes, it is, but luckily nobody is using the module with the slot enabled yet. The only project is io-services-cms, which developers suggested the fix

Exactly, only reference found is io-p-itn-svc-bo-app-01

christian-calabrese commented 1 month ago

is it possible that the deploy pipeline points to the old name?

In the module from terraform-azurerm-v3, the name of the slot is chosen by the user, so it shouldn't be an issue