pagopa-github-bot
commented
3 months ago Affected stories
- ⚙️ IOAPPX-296: Rimozione native-base da io-app
Generated by :no_entry_sign: dangerJS against cb2bc47bcdd40033e2bcd144b09291a0f8de084c
Closed CrisTofani closed 3 weeks ago
pagopa-github-bot
commented
3 months ago Generated by :no_entry_sign: dangerJS against cb2bc47bcdd40033e2bcd144b09291a0f8de084c
dpulls[bot]
commented
2 months ago :tada: All dependencies have been resolved !
CrisTofani
commented
1 month ago e2e tests running here https://github.com/pagopa/io-app/actions/runs/8718945245
CrisTofani
commented
1 month ago @LazyAfternoons Apparently some library is still using the prop-type raising the error, btw react-native reduced this to a warning and not an error in the 0.71, so i guess we will anyway remove the patch in future
dmnplb
commented
1 month ago @LazyAfternoons @CrisTofani Also removed the react-native-iphone-x-helper dependency in the following commit: https://github.com/pagopa/io-app/pull/5558/commits/9642b1f01c6d246c7ddba9818a4aa1ce77e575ee
codecov[bot]
commented
1 month ago Attention: Patch coverage is 31.42077% with 251 lines in your changes are missing coverage. Please review.
Project coverage is 49.59%. Comparing base (
4f204b4) to head (cb2bc47). Report is 71 commits behind head on master.
dmnplb
commented
1 month ago Tested on the main flows I have only encountered a little issue on IDPay IDPAY_ONBOARDING_INITIATIVE_DETAILS screen not necessarily related to the native-based.
@hevelius Good catch! It's probably caused by the edits made in this PR. Let me check 👀
dmnplb
commented
1 month ago @hevelius Changed IDPay related screens in the following commit → https://github.com/pagopa/io-app/pull/5558/commits/a6077741cf2eb5ff9f7ba9a301d2d7b5e201c352 Changes applied:
BaseScreenComponent and SafeAreaView (the combination caused bugs)useHeaderSecondLevel hook to add missing header (previously managed by BaseScreenComponent)I have tested the entire onboarding flow and it seems to work well (cc @mastro993)
CrisTofani
commented
1 month ago I'm not able to login with Test accounts anymore both on Android and iOS? It seems that text inputs are disabled in some way. Can we do a double check?
Demo testlogin-ko.mov
@shadowsheep1 what do you think if we change the components input with the new TextInput component?
shadowsheep1
commented
1 month ago I'm not able to login with Test accounts anymore both on Android and iOS? It seems that text inputs are disabled in some way. Can we do a double check? Demo testlogin-ko.mov
@shadowsheep1 what do you think if we change the components input with the new TextInput component?
No problem! We could even use the one from DS ;)
CrisTofani
commented
1 month ago I'm not able to login with Test accounts anymore both on Android and iOS? It seems that text inputs are disabled in some way. Can we do a double check? Demo testlogin-ko.mov
@shadowsheep1 what do you think if we change the components input with the new TextInput component?
No problem! We could even use the one from DS ;)
@shadowsheep1 addressed in 101996f
shadowsheep1
commented
1 month ago I'm not able to login with Test accounts anymore both on Android and iOS? It seems that text inputs are disabled in some way. Can we do a double check? Demo testlogin-ko.mov
@shadowsheep1 what do you think if we change the components input with the new TextInput component?
No problem! We could even use the one from DS ;)
@shadowsheep1 addressed in 101996f
Superb! ❤️
dmnplb
commented
3 weeks ago We should check the Payments and Messages related flows to be safe. If nothing is broken, we should merge. What do you think?
shadowsheep1
commented
3 weeks ago We should check the
PaymentsandMessagesrelated flows to be safe. If nothing is broken, we should merge. What do you think?
It seems that the testID on TextInputValidation and TextInputPassword is not well propagated... what do you think?
<TextInput
accessibilityLabel="Password"
accessibilityState={
Object {
"disabled": false,
}
}
accessible={true}
blurOnSubmit={true}
cursorColor="#0B3EE3"
disableFullscreenUI={true}
editable={true}
inputMode="password"
onBlur={[Function]}
onChangeText={[Function]}
onFocus={[Function]}
returnKeyType="done"
secureTextEntry={true}
selectionColor="#0B3EE3"
style={
Array [
Object {
"flex": 1,
"fontSize": 16,
"height": "100%",
"lineHeight": 24,
"marginTop": 8,
},
Object {
"fontFamily": "Titillium Web",
"fontStyle": "normal",
"fontWeight": "600",
},
]
}
value=""
/>It seems that the testID on TextInputValidation and TextInputPassword is not well propagated... what do you think?
@shadowsheep1 A fix has been already released in the io-app-design-system package:
The tests will be fixed soon, but on the authentication side we should be safe thanks to your review
CrisTofani
commented
3 weeks ago We should check the
PaymentsandMessagesrelated flows to be safe. If nothing is broken, we should merge. What do you think?It seems that the
testIDonTextInputValidationandTextInputPasswordis not well propagated... what do you think?@shadowsheep1 Addressed in the last 2 commits now it should be fine
Short description
This PR removes
native-baseand its related packages from dependencies.List of changes proposed in this pull request
native-baseand relative themeHeaderandStyleProvidercomponentsContentandFormcomponentsToast(fromnative-base) with the newIOToastfromio-app-design-systemFooterWithButtons(based onnative-basebuttons) with the newFooterWithButtonsfromio-app-design-systemListItemComponentwithPressablenative component, waiting for the complete overhaul with the newio-app-design-systemcomponentsTextInputwith the native onereact-native-iphone-x-helperandreact-native-keyboard-aware-scroll-viewunused dependenciesCredits
This PR is the result of:
How to test
Launch the app in the local environment and accurately test the most used flows by the citizens, especially: