feat: [IOCOM-1207] Payment data on the "More info" bottom sheet

Vangaorth commented 4 weeks ago

Short description

This PR adds the payment data (notice number and payee fiscal code) to the "More info" bottom sheet, in the message details screen, with the new DS enabled.

No payment data	With payment data

List of changes proposed in this pull request

ShowMoreListItem supports the visualisation of payment's notice code and payee's fiscal code.
New formatPaymentNoticeNumber function, in order to share common formatting logic for a notice number

How to test

Using the io-dev-api-server, generate a message without a payment and a message with a payment. Check that the former does not show any payment info while the latter does.

pagopa-github-bot commented 4 weeks ago

Affected stories

🌟 IOCOM-1207: [App] Aggiungere l'id del pagamento al bottom sheet che compare sulla funzionalità "Mostra altri dati" subtask of
- ⚡ IOCOM-812: Adottare il nuovo design system nel dettaglio di un messaggio di IO

Generated by :no_entry_sign: dangerJS against f6ab3f57f5dadb9008d03f4c0ec5d3ba665e5d78

mastro993 commented 4 weeks ago

LGTM for the formatPaymentNoticeNumber utility function and refactoring made in the payments feature!

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 48.35%. Comparing base (4f204b4) to head (ebaa47f). Report is 4 commits behind head on master.

:exclamation: Current head ebaa47f differs from pull request most recent head f6ab3f5. Consider uploading reports for the commit f6ab3f5 to get more accurate results

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/pagopa/io-app/pull/5695/graphs/tree.svg?width=650&height=150&src=pr&token=zsurlZdPFW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa)](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ```diff @@ Coverage Diff @@ ## master #5695 +/- ## ========================================== - Coverage 48.42% 48.35% -0.07% ========================================== Files 1488 1485 -3 Lines 31617 31573 -44 Branches 7669 7662 -7 ========================================== - Hits 15311 15268 -43 + Misses 16238 16237 -1 Partials 68 68 ``` | [Files](https://app.codecov.io/gh/pagopa/io-app/pull/5695?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) | Coverage Δ | | |---|---|---| | [.../components/MessageDetail/MessageDetailsFooter.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fcomponents%2FMessageDetail%2FMessageDetailsFooter.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvY29tcG9uZW50cy9NZXNzYWdlRGV0YWlsL01lc3NhZ2VEZXRhaWxzRm9vdGVyLnRzeA==) | `100.00% <ø> (ø)` | | | [...es/components/MessageDetail/MessagePaymentItem.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fcomponents%2FMessageDetail%2FMessagePaymentItem.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvY29tcG9uZW50cy9NZXNzYWdlRGV0YWlsL01lc3NhZ2VQYXltZW50SXRlbS50c3g=) | `91.52% <100.00%> (-1.70%)` | :arrow_down: | | [...features/messages/screens/MessageDetailsScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fscreens%2FMessageDetailsScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvc2NyZWVucy9NZXNzYWdlRGV0YWlsc1NjcmVlbi50c3g=) | `79.54% <ø> (ø)` | | | [...nts/checkout/screens/WalletPaymentDetailScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Fscreens%2FWalletPaymentDetailScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvc2NyZWVucy9XYWxsZXRQYXltZW50RGV0YWlsU2NyZWVuLnRzeA==) | `9.30% <ø> (+0.21%)` | :arrow_up: | | [ts/features/payments/common/utils/index.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcommon%2Futils%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY29tbW9uL3V0aWxzL2luZGV4LnRz) | `41.66% <100.00%> (+2.01%)` | :arrow_up: | | [ts/features/pn/screens/LegacyPaidPaymentScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpn%2Fscreens%2FLegacyPaidPaymentScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcG4vc2NyZWVucy9MZWdhY3lQYWlkUGF5bWVudFNjcmVlbi50c3g=) | `80.00% <100.00%> (ø)` | | | [...s/checkout/hooks/usePaymentFailureSupportModal.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Fhooks%2FusePaymentFailureSupportModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvaG9va3MvdXNlUGF5bWVudEZhaWx1cmVTdXBwb3J0TW9kYWwudHN4) | `2.04% <0.00%> (ø)` | | | [...s/wallet/payment/components/TransactionSummary.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Fscreens%2Fwallet%2Fpayment%2Fcomponents%2FTransactionSummary.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvc2NyZWVucy93YWxsZXQvcGF5bWVudC9jb21wb25lbnRzL1RyYW5zYWN0aW9uU3VtbWFyeS50c3g=) | `10.52% <0.00%> (ø)` | | | [...ages/components/MessageDetail/ShowMoreListItem.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5695?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fcomponents%2FMessageDetail%2FShowMoreListItem.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvY29tcG9uZW50cy9NZXNzYWdlRGV0YWlsL1Nob3dNb3JlTGlzdEl0ZW0udHN4) | `80.00% <76.92%> (+5.00%)` | :arrow_up: | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/pagopa/io-app/pull/5695/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pagopa/io-app/pull/5695?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pagopa/io-app/pull/5695?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Last update [96d0120...f6ab3f5](https://app.codecov.io/gh/pagopa/io-app/pull/5695?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa).

pagopa / io-app