feat: [IOPID-1503] Adopt the new DS on `CiePinScreen`

shadowsheep1 commented 3 weeks ago

Short description

This PR addresses the redesign of RootedModal by adopting the new DS.

[!TIP] Review Privacy ✅ Translations ⏳

[!CAUTION] Depends on https://github.com/pagopa/io-app/pull/5686

Demo

| 🤖 a11y | 🍏 a11y | | - | - | |

List of changes proposed in this pull request

Use the new OTPInput in CiePinScreen.
Remove unused component CiePinpad.
Bump io-app-design-system from 1.34.0 to 1.36.1 to use OTPInput a11y improvements and to be able to empty its value from the parent component.

How to test

Run the app both on Anroid and iOS physical devices:

On LandingPage triple tap on pager-dots to show the UAT CIE selection screen. Try the OTPInput here. It should work as expected.
Try to login with CIE (for iOS, you'd previously run yarn cie-ios:prod), and on CiePinScreen check that all works as expected.

pagopa-github-bot commented 3 weeks ago

Affected stories

🌟 IOPID-1503: [DS-CIE][APP] CIE Pin Screen subtask of
- ⚡ IOPID-1722: DS - Entra con CIE

Generated by :no_entry_sign: dangerJS against cf4b9e4311c3cec8a8f1a13356fda3cd07803021

shadowsheep1 commented 3 weeks ago

@mariateresaventura Maybe the EN and DE translations are already good, so I didn't change them:

DE: pinCardTitle: "Gib die PIN deiner Identitätskarte ein"
EN: pinCardTitle: Enter the PIN of your ID Card

What do you think?

dpulls[bot] commented 3 weeks ago

:tada: All dependencies have been resolved !

mariateresaventura commented 2 weeks ago

@mariateresaventura Maybe the EN and DE translations are already good, so I didn't change them:
DE: pinCardTitle: "Gib die PIN deiner Identitätskarte ein"
EN: pinCardTitle: Enter the PIN of your ID Card
What do you think?

LGTM!

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 48.80%. Comparing base (4f204b4) to head (cf4b9e4). Report is 28 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/pagopa/io-app/pull/5705/graphs/tree.svg?width=650&height=150&src=pr&token=zsurlZdPFW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa)](https://app.codecov.io/gh/pagopa/io-app/pull/5705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ```diff @@ Coverage Diff @@ ## master #5705 +/- ## ========================================== + Coverage 48.42% 48.80% +0.37% ========================================== Files 1488 1578 +90 Lines 31617 31799 +182 Branches 7669 7707 +38 ========================================== + Hits 15311 15518 +207 + Misses 16238 16223 -15 + Partials 68 58 -10 ``` | [Files](https://app.codecov.io/gh/pagopa/io-app/pull/5705?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) | Coverage Δ | | |---|---|---| | [ts/navigation/AuthenticationNavigator.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5705?src=pr&el=tree&filepath=ts%2Fnavigation%2FAuthenticationNavigator.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvbmF2aWdhdGlvbi9BdXRoZW50aWNhdGlvbk5hdmlnYXRvci50c3g=) | `40.00% <ø> (ø)` | | | [...eLogin/components/screens/CieLoginConfigScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5705?src=pr&el=tree&filepath=ts%2Ffeatures%2FcieLogin%2Fcomponents%2Fscreens%2FCieLoginConfigScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvY2llTG9naW4vY29tcG9uZW50cy9zY3JlZW5zL0NpZUxvZ2luQ29uZmlnU2NyZWVuLnRzeA==) | `18.75% <25.00%> (+6.98%)` | :arrow_up: | | [ts/screens/authentication/cie/CiePinScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5705?src=pr&el=tree&filepath=ts%2Fscreens%2Fauthentication%2Fcie%2FCiePinScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvc2NyZWVucy9hdXRoZW50aWNhdGlvbi9jaWUvQ2llUGluU2NyZWVuLnRzeA==) | `7.27% <8.33%> (-4.50%)` | :arrow_down: | ... and [116 files with indirect coverage changes](https://app.codecov.io/gh/pagopa/io-app/pull/5705/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pagopa/io-app/pull/5705?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pagopa/io-app/pull/5705?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Last update [83f63ca...cf4b9e4](https://app.codecov.io/gh/pagopa/io-app/pull/5705?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa).

pagopa / io-app