pagopa / io-app

IO, l'app dei servizi pubblici
https://io.italia.it
European Union Public License 1.2
567 stars 98 forks source link

chore: [IOPAE-1069] MyPortal reference code removal #5708

Closed giuseppedipinto closed 3 weeks ago

giuseppedipinto commented 3 weeks ago

Short description

This PR removes the reference code for the MyPortal initiative (which never went into production).

List of changes proposed in this pull request

How to test

pagopa-github-bot commented 3 weeks ago

Affected stories

Generated by :no_entry_sign: dangerJS against fcb015398e7f56c07b3c1a84976b63aa35ee0279

giuseppedipinto commented 3 weeks ago

I still see a few references to MyPortal in:

  • messages.test.ts;
  • testFaker.ts;
  • MYPORTAL_README.md;

Should we clear them up as well? What do you think?

@LazyAfternoons I think it's a great suggestion, thanks, commit here 2d4bff4e8. I only have a doubt about testFaker.ts, because the PublicSession interface defines (and shares with the backend) myPortalToken as the required property, and therefore should be handled as a blocking dependency. I suggest to resume this point when the same code removal will be done on the io-backend repo.

LazyAfternoons commented 3 weeks ago

myPortalToken

Makes sense, let's address this later when the type is changed accordingly.