Closed ChrisMattew closed 1 week ago
Warnings | |
---|---|
:warning: | Multiple stories with different types are associated with this Pull request. Only one tag will be added, following the order: `feature > bug > chore` |
Generated by :no_entry_sign: dangerJS against c884ec88bc9a1acd4d321833468f421a0057da91
@mariateresaventura copy needs a review ππΌ
@mariateresaventura copy needs a review ππΌ
Done!
Attention: Patch coverage is 70.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 48.82%. Comparing base (
4f204b4
) to head (c884ec8
). Report is 34 commits behind head on master.
Short description
Integrate new DS in UpdateAppModal and adjust key duplication in OperationResultScreenContent component
List of changes proposed in this pull request
E2E
Screens
iOS simulator
| Open link success | Open link error | | - | - | | | |
Android device
| Open link success | Open link error | | - | - | | | |
How to test
There are two ways is which test this case:
ts/screens/modal/RootModal.tsx
invert the!props.isAppSupported
condition to display the UpdateAppModal screenassets/status/versionInfo.json
and change the version related to the OS of your device/simulator in order to display the UpdateAppModal in your app.Android virtual device additional setup
In `ts/sagas/startup.ts` find and comment the code snippets shown here below: ```tsx // this const unsupportedDevice = yield* call(checkPublicKeyAndBlockIfNeeded); if (unsupportedDevice) { return; } // and this const isAssertionRefValid = yield* call( checkLollipopSessionAssertionAndInvalidateIfNeeded, publicKey, maybeSessionInformation ); if (!isAssertionRefValid) { return; } ``` then follow the process already explained in the section above.