pagopa / io-app

IO, l'app dei servizi pubblici
https://io.italia.it
European Union Public License 1.2
567 stars 98 forks source link

feat: [IOPID-1539,IOPID-1784] - Integrate new DS in UpdateAppModal #5710

Closed ChrisMattew closed 1 week ago

ChrisMattew commented 3 weeks ago

Short description

Integrate new DS in UpdateAppModal and adjust key duplication in OperationResultScreenContent component

List of changes proposed in this pull request

E2E

[!Tip] Run e2e tests

Screens

iOS simulator

| Open link success | Open link error | | - | - | |

Android device

| Open link success | Open link error | | - | - | |

How to test

There are two ways is which test this case:

  1. In ts/screens/modal/RootModal.tsx invert the !props.isAppSupported condition to display the UpdateAppModal screen
  2. Testing in local environment - clone io-dev-api-server repo if you haven't did it yet and follow the instructions - go in assets/status/versionInfo.json and change the version related to the OS of your device/simulator in order to display the UpdateAppModal in your app.
    "min_app_version": {
    "ios": "x.y.z",
    "android": "x.y.z"
    }

[!IMPORTANT]
Testing with an android virtual device requires an additional setup before to start!

Android virtual device additional setup

In `ts/sagas/startup.ts` find and comment the code snippets shown here below: ```tsx // this const unsupportedDevice = yield* call(checkPublicKeyAndBlockIfNeeded); if (unsupportedDevice) { return; } // and this const isAssertionRefValid = yield* call( checkLollipopSessionAssertionAndInvalidateIfNeeded, publicKey, maybeSessionInformation ); if (!isAssertionRefValid) { return; } ``` then follow the process already explained in the section above.

pagopa-github-bot commented 3 weeks ago
Warnings
:warning: Multiple stories with different types are associated with this Pull request. Only one tag will be added, following the order: `feature > bug > chore`

Affected stories

Generated by :no_entry_sign: dangerJS against c884ec88bc9a1acd4d321833468f421a0057da91

ChrisMattew commented 3 weeks ago

@mariateresaventura copy needs a review πŸ™πŸΌ

mariateresaventura commented 2 weeks ago

@mariateresaventura copy needs a review πŸ™πŸΌ

Done!

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 48.82%. Comparing base (4f204b4) to head (c884ec8). Report is 34 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pagopa/io-app/pull/5710/graphs/tree.svg?width=650&height=150&src=pr&token=zsurlZdPFW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa)](https://app.codecov.io/gh/pagopa/io-app/pull/5710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ```diff @@ Coverage Diff @@ ## master #5710 +/- ## ========================================== + Coverage 48.42% 48.82% +0.40% ========================================== Files 1488 1579 +91 Lines 31617 31813 +196 Branches 7669 7711 +42 ========================================== + Hits 15311 15534 +223 + Misses 16238 16221 -17 + Partials 68 58 -10 ``` | [Files](https://app.codecov.io/gh/pagopa/io-app/pull/5710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) | Coverage Ξ” | | |---|---|---| | [...omponents/screens/OperationResultScreenContent.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5710?src=pr&el=tree&filepath=ts%2Fcomponents%2Fscreens%2FOperationResultScreenContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvY29tcG9uZW50cy9zY3JlZW5zL09wZXJhdGlvblJlc3VsdFNjcmVlbkNvbnRlbnQudHN4) | `76.19% <0.00%> (ΓΈ)` | | | [ts/screens/modal/UpdateAppModal.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5710?src=pr&el=tree&filepath=ts%2Fscreens%2Fmodal%2FUpdateAppModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvc2NyZWVucy9tb2RhbC9VcGRhdGVBcHBNb2RhbC50c3g=) | `70.37% <73.68%> (+14.81%)` | :arrow_up: | ... and [118 files with indirect coverage changes](https://app.codecov.io/gh/pagopa/io-app/pull/5710/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pagopa/io-app/pull/5710?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pagopa/io-app/pull/5710?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Last update [2689389...c884ec8](https://app.codecov.io/gh/pagopa/io-app/pull/5710?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa).