pagopa / io-app

IO, l'app dei servizi pubblici
https://io.italia.it
European Union Public License 1.2
567 stars 98 forks source link

feat: [IOCOM-1285] Remote content banner, new DS #5721

Closed Vangaorth closed 1 week ago

Vangaorth commented 2 weeks ago

Short description

This PR adds the "This message's content is remote" banner to the message's details screen, with the new DS It also refactors the ComposedBodyFromArray component by extracting it into its own file.

Banner Bottom Sheet
Simulator Screenshot - iPhone 15 - 2024-04-24 at 15 35 01 Simulator Screenshot - iPhone 15 - 2024-04-24 at 16 44 26

List of changes proposed in this pull request

How to test

Using the io-dev-api-server, generate both a standard and a remote-content message:

Vangaorth commented 2 weeks ago

@Ladirico for the approval (or rejection) of the refactored ComposedBodyFromArray component

pagopa-github-bot commented 2 weeks ago

Affected stories

Generated by :no_entry_sign: dangerJS against b47b4ffcd633af3d70a7858f56d9a0d5166a0ea4

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 48.88%. Comparing base (4f204b4) to head (b47b4ff). Report is 44 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pagopa/io-app/pull/5721/graphs/tree.svg?width=650&height=150&src=pr&token=zsurlZdPFW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa)](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ```diff @@ Coverage Diff @@ ## master #5721 +/- ## ========================================== + Coverage 48.42% 48.88% +0.45% ========================================== Files 1488 1588 +100 Lines 31617 31972 +355 Branches 7669 7749 +80 ========================================== + Hits 15311 15628 +317 - Misses 16238 16276 +38 Partials 68 68 ``` | [Files](https://app.codecov.io/gh/pagopa/io-app/pull/5721?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) | Coverage Δ | | |---|---|---| | [...mponents/core/typography/ComposedBodyFromArray.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Fcomponents%2Fcore%2Ftypography%2FComposedBodyFromArray.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvY29tcG9uZW50cy9jb3JlL3R5cG9ncmFwaHkvQ29tcG9zZWRCb2R5RnJvbUFycmF5LnRzeA==) | `100.00% <100.00%> (ø)` | | | [...res/design-system/core/DSScreenOperationResult.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Ffeatures%2Fdesign-system%2Fcore%2FDSScreenOperationResult.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvZGVzaWduLXN5c3RlbS9jb3JlL0RTU2NyZWVuT3BlcmF0aW9uUmVzdWx0LnRzeA==) | `16.66% <ø> (ø)` | | | [...atures/messages/components/MessageDetail/index.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fcomponents%2FMessageDetail%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvY29tcG9uZW50cy9NZXNzYWdlRGV0YWlsL2luZGV4LnRzeA==) | `54.00% <ø> (ø)` | | | [...features/messages/screens/MessageDetailsScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fscreens%2FMessageDetailsScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvc2NyZWVucy9NZXNzYWdlRGV0YWlsc1NjcmVlbi50c3g=) | `80.43% <100.00%> (+0.88%)` | :arrow_up: | | [...eens/profile/mailCheck/EmailAlreadyTakenScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Fscreens%2Fprofile%2FmailCheck%2FEmailAlreadyTakenScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvc2NyZWVucy9wcm9maWxlL21haWxDaGVjay9FbWFpbEFscmVhZHlUYWtlblNjcmVlbi50c3g=) | `10.52% <ø> (ø)` | | | [.../screens/profile/mailCheck/ValidateEmailScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Fscreens%2Fprofile%2FmailCheck%2FValidateEmailScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvc2NyZWVucy9wcm9maWxlL21haWxDaGVjay9WYWxpZGF0ZUVtYWlsU2NyZWVuLnRzeA==) | `4.54% <ø> (ø)` | | | [...omponents/screens/OperationResultScreenContent.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Fcomponents%2Fscreens%2FOperationResultScreenContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvY29tcG9uZW50cy9zY3JlZW5zL09wZXJhdGlvblJlc3VsdFNjcmVlbkNvbnRlbnQudHN4) | `88.23% <0.00%> (+12.04%)` | :arrow_up: | | [...s/components/MessageDetail/RemoteContentBanner.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fcomponents%2FMessageDetail%2FRemoteContentBanner.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvY29tcG9uZW50cy9NZXNzYWdlRGV0YWlsL1JlbW90ZUNvbnRlbnRCYW5uZXIudHN4) | `70.00% <57.14%> (+53.33%)` | :arrow_up: | | [...onents/MessageDetail/LegacyRemoteContentBanner.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5721?src=pr&el=tree&filepath=ts%2Ffeatures%2Fmessages%2Fcomponents%2FMessageDetail%2FLegacyRemoteContentBanner.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvbWVzc2FnZXMvY29tcG9uZW50cy9NZXNzYWdlRGV0YWlsL0xlZ2FjeVJlbW90ZUNvbnRlbnRCYW5uZXIudHN4) | `16.66% <16.66%> (ø)` | | ... and [148 files with indirect coverage changes](https://app.codecov.io/gh/pagopa/io-app/pull/5721/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pagopa/io-app/pull/5721?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pagopa/io-app/pull/5721?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Last update [685d600...b47b4ff](https://app.codecov.io/gh/pagopa/io-app/pull/5721?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa).