pagopa / io-app

IO, l'app dei servizi pubblici
https://io.italia.it
European Union Public License 1.2
567 stars 98 forks source link

chore: [IOBP-629] Add onboarding payment method when not found any #5722

Closed Hantex9 closed 1 week ago

Hantex9 commented 2 weeks ago

Short description

This PR implements the possibility to add a new payment method during the checkout, being able to resume the payment flow once the method has been successfully added.

N.B: ⚠ This behavior has been implemented for a transitional phase with the current PM, as soon as the backend is fully migrated to NPG, this functionality will become deprecated and thus must be removed (reported in the following ticket: https://pagopa.atlassian.net/browse/IOBP-632)

List of changes proposed in this pull request

How to test

Preview

https://github.com/pagopa/io-app/assets/34343582/4c524682-61ac-497a-8804-fa7aca3110db

pagopa-github-bot commented 2 weeks ago

Affected stories

Generated by :no_entry_sign: dangerJS against 09091f5dd9eae4ab4fad19289bb78571c566a986

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 8.51064% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 48.84%. Comparing base (4f204b4) to head (09091f5). Report is 41 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pagopa/io-app/pull/5722/graphs/tree.svg?width=650&height=150&src=pr&token=zsurlZdPFW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa)](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ```diff @@ Coverage Diff @@ ## master #5722 +/- ## ========================================== + Coverage 48.42% 48.84% +0.41% ========================================== Files 1488 1585 +97 Lines 31617 31949 +332 Branches 7669 7796 +127 ========================================== + Hits 15311 15605 +294 - Misses 16238 16276 +38 Partials 68 68 ``` | [Files](https://app.codecov.io/gh/pagopa/io-app/pull/5722?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) | Coverage Δ | | |---|---|---| | [...ures/payments/checkout/types/PaymentOutcomeEnum.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Ftypes%2FPaymentOutcomeEnum.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvdHlwZXMvUGF5bWVudE91dGNvbWVFbnVtLnRz) | `25.00% <ø> (ø)` | | | [...eatures/payments/onboarding/store/actions/index.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fonboarding%2Fstore%2Factions%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvb25ib2FyZGluZy9zdG9yZS9hY3Rpb25zL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | | [...tures/payments/onboarding/store/selectors/index.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fonboarding%2Fstore%2Fselectors%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvb25ib2FyZGluZy9zdG9yZS9zZWxlY3RvcnMvaW5kZXgudHM=) | `35.71% <50.00%> (+2.38%)` | :arrow_up: | | [...checkout/components/CheckoutPaymentMethodsList.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Fcomponents%2FCheckoutPaymentMethodsList.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvY29tcG9uZW50cy9DaGVja291dFBheW1lbnRNZXRob2RzTGlzdC50c3g=) | `5.79% <0.00%> (ø)` | | | [...atures/payments/onboarding/store/reducers/index.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fonboarding%2Fstore%2Freducers%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvb25ib2FyZGluZy9zdG9yZS9yZWR1Y2Vycy9pbmRleC50cw==) | `23.07% <0.00%> (-4.20%)` | :arrow_down: | | [...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Fscreens%2FWalletPaymentOutcomeScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvc2NyZWVucy9XYWxsZXRQYXltZW50T3V0Y29tZVNjcmVlbi50c3g=) | `1.44% <0.00%> (-0.12%)` | :arrow_down: | | [...checkout/screens/WalletPaymentPickMethodScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Fscreens%2FWalletPaymentPickMethodScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvc2NyZWVucy9XYWxsZXRQYXltZW50UGlja01ldGhvZFNjcmVlbi50c3g=) | `1.56% <0.00%> (-4.75%)` | :arrow_down: | | [...ayments/checkout/store/selectors/paymentMethods.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fcheckout%2Fstore%2Fselectors%2FpaymentMethods.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvY2hlY2tvdXQvc3RvcmUvc2VsZWN0b3JzL3BheW1lbnRNZXRob2RzLnRz) | `25.00% <8.33%> (ø)` | | | [...rding/screens/PaymentsOnboardingFeedbackScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5722?src=pr&el=tree&filepath=ts%2Ffeatures%2Fpayments%2Fonboarding%2Fscreens%2FPaymentsOnboardingFeedbackScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvcGF5bWVudHMvb25ib2FyZGluZy9zY3JlZW5zL1BheW1lbnRzT25ib2FyZGluZ0ZlZWRiYWNrU2NyZWVuLnRzeA==) | `6.89% <0.00%> (-4.22%)` | :arrow_down: | ... and [129 files with indirect coverage changes](https://app.codecov.io/gh/pagopa/io-app/pull/5722/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pagopa/io-app/pull/5722?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pagopa/io-app/pull/5722?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Last update [63144e7...09091f5](https://app.codecov.io/gh/pagopa/io-app/pull/5722?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa).