pagopa / io-app

IO, l'app dei servizi pubblici
https://io.italia.it
European Union Public License 1.2
567 stars 97 forks source link

feat(IT Wallet): [SIW-979] Add issuing authentication mode selection screen #5729

Closed mastro993 closed 3 weeks ago

mastro993 commented 4 weeks ago

Short description

This PR adds the authentication method selection screen, required for credentials issuing for the IT Wallet.

List of changes proposed in this pull request

How to test

Navigate to Profile > IT Wallet > Issuing, check that the new screen is correctly rendered.

Preview

pagopa-github-bot commented 4 weeks ago

Affected stories

Generated by :no_entry_sign: dangerJS against 2006dd2fe20801713400bdd0e4d71de796971911

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 48.91%. Comparing base (4f204b4) to head (2006dd2). Report is 51 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pagopa/io-app/pull/5729/graphs/tree.svg?width=650&height=150&src=pr&token=zsurlZdPFW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa)](https://app.codecov.io/gh/pagopa/io-app/pull/5729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ```diff @@ Coverage Diff @@ ## master #5729 +/- ## ========================================== + Coverage 48.42% 48.91% +0.48% ========================================== Files 1488 1590 +102 Lines 31617 32019 +402 Branches 7669 7754 +85 ========================================== + Hits 15311 15661 +350 - Misses 16238 16300 +62 + Partials 68 58 -10 ``` | [Files](https://app.codecov.io/gh/pagopa/io-app/pull/5729?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) | Coverage Δ | | |---|---|---| | [...features/itwallet/navigation/ItwStackNavigator.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5729?src=pr&el=tree&filepath=ts%2Ffeatures%2Fitwallet%2Fnavigation%2FItwStackNavigator.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvaXR3YWxsZXQvbmF2aWdhdGlvbi9JdHdTdGFja05hdmlnYXRvci50c3g=) | `66.66% <ø> (ø)` | | | [ts/features/itwallet/navigation/routes.ts](https://app.codecov.io/gh/pagopa/io-app/pull/5729?src=pr&el=tree&filepath=ts%2Ffeatures%2Fitwallet%2Fnavigation%2Froutes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvaXR3YWxsZXQvbmF2aWdhdGlvbi9yb3V0ZXMudHM=) | `100.00% <ø> (ø)` | | | [ts/screens/profile/playgrounds/ItwPlayground.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5729?src=pr&el=tree&filepath=ts%2Fscreens%2Fprofile%2Fplaygrounds%2FItwPlayground.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvc2NyZWVucy9wcm9maWxlL3BsYXlncm91bmRzL0l0d1BsYXlncm91bmQudHN4) | `16.66% <0.00%> (-8.34%)` | :arrow_down: | | [...n/screens/ItwIdentificationModeSelectionScreen.tsx](https://app.codecov.io/gh/pagopa/io-app/pull/5729?src=pr&el=tree&filepath=ts%2Ffeatures%2Fitwallet%2Fidentification%2Fscreens%2FItwIdentificationModeSelectionScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa#diff-dHMvZmVhdHVyZXMvaXR3YWxsZXQvaWRlbnRpZmljYXRpb24vc2NyZWVucy9JdHdJZGVudGlmaWNhdGlvbk1vZGVTZWxlY3Rpb25TY3JlZW4udHN4) | `4.54% <4.54%> (ø)` | | ... and [197 files with indirect coverage changes](https://app.codecov.io/gh/pagopa/io-app/pull/5729/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pagopa/io-app/pull/5729?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pagopa/io-app/pull/5729?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Last update [789dbdc...2006dd2](https://app.codecov.io/gh/pagopa/io-app/pull/5729?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pagopa).
mastro993 commented 3 weeks ago

Side note, should we rename authentication to identification? Does it makes sense to you since the citizen is already authenticated at this point?

Yes, it makes sense completely! I will make the change with the next commit.