search

pahen / madge

Create graphs from your CommonJS, AMD or ES6 module dependencies
MIT License
9.06k stars 317 forks source link

Replace to ts-graphviz package #341

Closed kamiazya closed 1 year ago

kamiazya commented 1 year ago

Hi,

I'm @kamiazya, the developer of the ts-graphviz package.

I was testing the possibility of replacing graphviz package's use cases with ts-graphviz using madge project.

I have successfully replaced the use cases of the graphviz package in madge with ts-graphviz and created a pull request.

Since the graphviz package is not actively maintained, I think I can contribute to closing issues that depend on the graphviz package, such as https://github.com/pahen/madge/issues/327.

In fact, ts-graphviz currently has no dependency on the temp package and works through a different mechanism, so it has not been tried, but https://github.com/pahen/madge/issues/327 is assumed to be resolved.

Thanks!

kamiazya commented 1 year ago

Oops, it seems that ts-graphviz fails on Node 10, 12, and 13 versions running on CI, since ts-graphviz supports Node 14 and above, in line with Node.js LTS.

https://endoflife.date/nodejs

Whether or not to support older Node versions depends on the policy of the package, so if the policy is to support LTS only, I would be happy to merge this pull request.

kamiazya commented 1 year ago

I created pull request to modify to support LTS only. https://github.com/pahen/madge/pull/342

As I mentioned in this pull request, I would be happy for you to decide if you want to merge with this project policy.