search

pahen / madge

Create graphs from your CommonJS, AMD or ES6 module dependencies
MIT License
9.09k stars 317 forks source link

Release a madge version to solve "Not all imports in TypeScript are detected" #402

Closed fcsonline closed 7 months ago

fcsonline commented 9 months ago

We have been facing some problem to detect all the dependencies from our project, and we have seen that are related to skipped files in madge.

There is an issue in this repository with the title "Not all imports in TypeScript are detected" marked as resolved, but the problem persists as there are some users reporting the same behaviour as we are facing: https://github.com/pahen/madge/issues/128 https://github.com/pahen/madge/issues/128#issuecomment-1914270074

It seems that the culprit of the problem was an issue in node-filing-cabinet and as consequence also in node-dependency-tree (10.*.*) that was solved months ago.

It looks like you are properly solved in main branch in madge but these changes have not been release in a proper NPM release, because the latest version 6.1.0 uses the buggy version.

We can use the workaround of using the git npm dependency, but it would be awesome to release a madge version to fix definitely this issue.

0kzh commented 9 months ago

Please! Tracing this bug was a pain

kainosnoema commented 9 months ago

Yes! We've been fighting with this for months, finally figured out that it was already fixed in main. Please release a new version @pahen. 🙏

cvoege commented 7 months ago

@pahen Are you still interested in maintaining this library? If not, would you be interested in passing it's stewardship along to another?

pahen commented 7 months ago

@pahen Are you still interested in maintaining this library? If not, would you be interested in passing it's stewardship along to another?

No, I'm not interested in maintaining this library anymore, see https://github.com/pahen/madge/issues/334

But I created a new major version and published it to NPM now :)

cvoege commented 7 months ago

@pahen Thank you! We all appreciate your contributions to open source very much!

fcsonline commented 7 months ago

Thank you so much @pahen for the release and for all the effort in this library!