search

pahen / madge

Create graphs from your CommonJS, AMD or ES6 module dependencies
MIT License
9.09k stars 317 forks source link

Update to dependency-tree@11 #417

Closed vikingair closed 6 months ago

vikingair commented 6 months ago

In this PR I updated to this release: https://github.com/dependents/node-dependency-tree/releases/tag/v11.0.0

Since the dependency dropped support for Node < 18, I did it here as well and adjusted the pipeline.

vikingair commented 6 months ago

@pahen How do you think about this?

I also tried adding a test to see that scanning Vue SFC files works, but couldn't find how I need to configure the detective to scan these files correctly. Maybe after merging this PR you have an idea?

pahen commented 6 months ago

@pahen How do you think about this?

I also tried adding a test to see that scanning Vue SFC files works, but couldn't find how I need to configure the detective to scan these files correctly. Maybe after merging this PR you have an idea?

Looks good! I don't use Vue myself but I suppose looking at this test might give us some help: https://github.com/dependents/detective-vue2/blob/main/test/test.js

vikingair commented 6 months ago

https://github.com/dependents/detective-vue2/blob/main/test/test.js

Will take a look and possibly add there more test cases. Especially, for different arrangements of top level tags and e.g. setup-syntax support. Will come back with my findings, once that would work, and add some tests for madge as well.

vikingair commented 6 months ago

Found the root cause of my issue and created a PR to fix it: https://github.com/dependents/detective-vue2/pull/5