Migrate to ESM - Githubissues

pahen / madge

Create graphs from your CommonJS, AMD or ES6 module dependencies

MIT License

8.71k stars 312 forks source link

Migrate to ESM #427

Open fdc-viktor-luft opened 3 weeks ago

fdc-viktor-luft commented 3 weeks ago

[ ] Verify that the generated output is still fine
[ ] Check that inclusion of package still works when installed
[ ] Fix broken test "supports resolve root paths in webpack config"

fdc-viktor-luft commented 3 weeks ago

@pahen This change was necessary in order to update some of the very outdated dependencies. Non-ESM projects will not be able to import "madge" anymore via "require". Hopefully, that is not a blocker, as CJS should be already abandoned by a large majority, especially as even more popular libs such as "chalk" have gone this path a long time ago.

What do you think?

And, do you have maybe an idea why the one remaining test might fail?