paideiadao / paideia-app

paideia-app.vercel.app
MIT License
5 stars 6 forks source link

Add `ErrorPage` and other improvements #86

Closed JoaoFGuiomar closed 9 months ago

JoaoFGuiomar commented 10 months ago

Description

This PR was supposed to only add a ErrorPage.

Eventually, it got out of hand 😅 :

Related Issue

Related PR

Screenshots

Screenshot 2023-10-13 at 21 03 28 Screenshot 2023-10-13 at 21 03 12

vercel[bot] commented 10 months ago

@JoaoFGuiomar is attempting to deploy a commit to the ergo-pad Team on Vercel.

A member of the Team first needs to authorize it.

esot321c commented 10 months ago

This is great. It will take us a bit to review all this but thank you, some of those are small annoyances that just needed a good cleanup. The "i" and "c" being used in map functions was a bit of a pet peeve so I like to see those getting replaced with something a bit more verbose ("i" should be used for index imo). Tons of bigger improvements too.

JoaoFGuiomar commented 10 months ago

@esot321c Rebased from beta and solved conflicts. Sorry about the long PR

noob77777 commented 9 months ago

Awesome work!!! But we could not merge this due to the large diff. But I have manually merged the changes in beta branch. Please reach out to @esot321c for the bounty.