search

paideiadao / paideia-app

paideia-app.vercel.app
MIT License
5 stars 6 forks source link

Add comment to list when creating a new comment #87

Closed JoaoFGuiomar closed 9 months ago

JoaoFGuiomar commented 10 months ago

Description

When Publishing a new comment, it was not appearing on the comment list without a page refresh. This PR adds reactive comments and the new ErrorPage message to the Wallet list (happen to have stumbled upon it)

Rebased fromfeat/improve-error-view/81

Screenshots

Comment is added after publish:

https://github.com/paideiadao/paideia-app/assets/2249046/dd7264a6-0549-4d36-941c-a641b0a392c0

If there's a network error we remove it:

https://github.com/paideiadao/paideia-app/assets/2249046/25488f06-5070-4f6a-84da-e38a05308ae8

Error page on Wallet list if address is invalid: Screenshot 2023-10-15 at 20 55 46

vercel[bot] commented 10 months ago

@JoaoFGuiomar is attempting to deploy a commit to the ergo-pad Team on Vercel.

A member of the Team first needs to authorize it.

esot321c commented 10 months ago

@JoaoFGuiomar were you working on the main branch? We have been working on beta branch for quite some time. I'm hoping we can eliminate any merge conflicts without too much trouble. I apologize for any time wasted, we were trying to keep bounties short partly to avoid any conflicts

JoaoFGuiomar commented 10 months ago

@JoaoFGuiomar were you working on the main branch? We have been working on beta branch for quite some time. I'm hoping we can eliminate any merge conflicts without too much trouble. I apologize for any time wasted, we were trying to keep bounties short partly to avoid any conflicts

I was. I can try to rebase and see how many conflicts appear and see if its manageable.

JoaoFGuiomar commented 10 months ago

@esot321c also updated this branch

Its rebased from feat/improve-error-view/81 which is rebased from beta When feat/improve-error-view/81 is merged, this PR will have a lot less changes. This is a small fix

esot321c commented 10 months ago

Hi @JoaoFGuiomar, we don't have the manpower to review a PR this big at the moment. Do you mind separating each update into a separate PR, and only linting the files you touched for that update? That way our team can review it properly. At the moment it will take us more time to review the PR than to actually do the bounties, which is counterproductive to the current goal of getting Paideia shipped to public beta. I hope you understand, we definitely appreciate the help!

noob77777 commented 9 months ago

Root cause was websockets not working. This is fixed now.