search

paiementstephanie / saas-on-the-run

0 stars 0 forks source link

Image Compression #2

Open paiementstephanie opened 8 years ago

paiementstephanie commented 8 years ago

@thomasjbradley

Hi Thomas,

I have a couple issues. The first one is that when I went to do the performance testing, I keep failing the image compression section, even though I smushed them all using the applications you showed us. And I even re-saved the images at a lower resolution in photoshop. I'm not sure how to proceed. As seen in the attached screen grab, all the other elements are ok.

The other problem is for my form submission, I keep getting a 404 error, even though I inserted the e-mail address like you showed us in class. I'm not sure how to proceed, I didn't get a confirmation e-mail from github for the e-mail.

screen shot 2015-12-13 at 9 44 12 pm
thomasjbradley commented 8 years ago

I don't see anything specifically wrong with your images, they all look good and compressed well.

Are there specific details when you click on the "F Compress Images" button?

The form error is confusing, and I don't completely know. Maybe try changing the http to https in the FormSpree URL?

paiementstephanie commented 8 years ago

only this, but I can't compress them anymore than they are.

screen shot 2015-12-15 at 2 42 37 pm
paiementstephanie commented 8 years ago
screen shot 2015-12-15 at 2 44 41 pm
thomasjbradley commented 8 years ago

I think it's as good as it's going to get. The load time is under 1s which is the most important thing!

paiementstephanie commented 8 years ago

okay perfect, so I won't get penalized for that section? all the other performance testing came back really well. Also, I noticed that this time it wasn't specified to send you screenshots of our performance testings. Do we still need to do this over github?

thomasjbradley commented 8 years ago

You don't need to do the screenshots, just hand in the URL like for every other assignment.