pail23 / stiebel_eltron_isg_component

Stiebel Eltron ISG integration for Home Assistant
MIT License
52 stars 22 forks source link

[Feature Request/FIX] SG Ready Status on LWZ/WPM #139

Open northalpha opened 1 year ago

northalpha commented 1 year ago

I do have an LWZ 5s plus with the optional EMI software extention for photovoltaic optimisation "Eigenverbraucherhöhung". So i am not sure if this is pre-requirement or not, i therefore kindly ask for implementing / correcting the

SG READY OPERATING STATE (SG READY BETRIEBSZUSTAND) in Register 5001

There should be 4 different status:

Screenshot 2023-10-27 at 14 28 40

Right now i am getting a constant reading of 32768 in that sensor. But looking at the ISG itself we can see that there is EM/EMI happening:

Screenshot 2023-10-27 at 14 22 04

So i do not know if this might be an exclusive "feature" only for ISG EMI customers (read: me) or general but please consider it implementing. Thanks!

guevara777 commented 1 year ago

image Works fine for my (WPL-07 HK 230 Premium)

pail23 commented 10 months ago

@northalpha Does this issue still exist in the latest version?

northalpha commented 10 months ago

sorry had to wait for right conditions, thats EMI kicks in ... and it is not working, the state of the sg ready sensor/entity was not changed :/

jaysus82 commented 9 months ago

I also tested this, and it's not working properly here too.

Screenshot_20240201_222948_Home Assistant I have 3 switching entities for SG Ready. The first one is a switch for the general status, if sg ready is activated or not. Input 1 and 2 are responsible for the four different sg ready states.

Operating state 1 (input 2/input 1): (1/0)- Standby operating temperatures in accordance with the operating and installation instructions for the connected heat pump - Frost protection is guaranteed Operating state 2: (0/0)- Automatic / program operation in accordance with the operating and installation instructions for the connected heat pump Operating state 3- : (0/1)- Forced operation with increased values for heating and hot water temperature (for configuration, see chapter "Energy management / Forced operation") Operating state 4- (1/1)- Immediate activation of the maximum values (fixed) for heating and hot water temperature

If I activate SG ready, and inputs 0/0, the heat pump immediately switches to state 3, which is wrong. State 2 should be the right one. Screenshot_20240201_223000_Home Assistant

Padanian commented 9 months ago

I'm not sure if this is related, @pail23

Both in lwz and wpm_coordinator it reads:

320 | """Write the data to the modbus."""
321 | if key == SG_READY_ACTIVE:
322 | self.write_register(address=4000, value=value, slave=1)
323 | elif key == SG_READY_INPUT_1:
324 | self.write_register(address=4001, value=value, slave=1)
325 | elif key == SG_READY_INPUT_2:

But activating the sg-ready function requires a logical 0, it might need reversing somewhere...

image

I confirm that when SG-ready is activated, its operating state is 2

image

and when disabled, its operating state is considered disabled, although such value is not in the enumeration of the ISG.

image

Padanian commented 9 months ago

I will contact the Germany headquarter for explanations.

jaysus82 commented 9 months ago

I now know why my SG Ready state was immediately "3" after switching SG ready "on". image These are the inputs read out via KNX, it shows that input 1 was set "on", so the result is SG ready state "3". But in Home Assistant, both inputs are still shown "off" or "0". image Seems this is somehow not synced. Edit: If i change input values via home assistant, nothing happens, if i write 1 on input 1 via knx, the state changes, but the input's change is not shown in Home assistant. I think both inputs are not really correctly connected. SG Ready state and activation status are working correct: image image

Padanian commented 9 months ago

SG Ready can only be commanded on one source:

image

In your case, KNX is selected.

Padanian commented 9 months ago

Anyway, there is something fishy, here.

C:\Users\xxxx\xxxx\Desktop>modpoll -m tcp -t 4 -c 1 -r 4001 -1 xx.xx.xx.xx modpoll 3.11 - FieldTalk(tm) Modbus(R) Master Simulator Copyright (c) 2002-2024 proconX Pty Ltd Visit https://www.modbusdriver.com for Modbus libraries and tools.

Protocol configuration: MODBUS/TCP, FC3 Slave configuration...: address = 1, start reference = 4001, count = 1 Communication.........: xx.xx.xx.xx, port 502, t/o 1.00 s, poll rate 1000 ms Data type.............: 16-bit register, output (holding) register table

-- Polling slave...

C:\Users\xxxx\xxxx\Desktop>modpoll -m tcp -t 3 -c 1 -r 5001 -1 xx.xx.xx.xx modpoll 3.11 - FieldTalk(tm) Modbus(R) Master Simulator Copyright (c) 2002-2024 proconX Pty Ltd Visit https://www.modbusdriver.com for Modbus libraries and tools.

Protocol configuration: MODBUS/TCP, FC4 Slave configuration...: address = 1, start reference = 5001, count = 1 Communication.........: xx.xx.xx.xx, port 502, t/o 1.00 s, poll rate 1000 ms Data type.............: 16-bit register, input register table

-- Polling slave...

Apparently I was able to activate SG Ready (4001 = 1 and the manuals says ON = 0, first problem), but the status is 5001 = 0 which is not in the enumeration. This is clearly a bug of the ISG firmware for the modbus API. I'll notify headquarter.

pail23 commented 9 months ago

@Padanian Interestingly, the German part of the modbus manual is different to the English part: grafik

It would be great if you could clarify which one is correct.

Padanian commented 9 months ago

Oh what a mess!

jaysus82 commented 9 months ago

SG Ready can only be commanded on one source:

In your case, KNX is selected.

Thanks! I don't need to command it, but it is also not possible to read the values from the input if KNX is selected ?

Padanian commented 9 months ago

It should be possible. That's what I will try to find out

northalpha commented 9 months ago

SG Ready can only be commanded on one source:

image

where can is see which source is selected?!

jaysus82 commented 9 months ago

It's under settings, energy management in the isg Web GUI. Screenshot_20240205_162042_Chrome

northalpha commented 9 months ago

aaah seems like it is only availble if your are not an EMI customer and therefore stick to software v12.1.2 because only newer version of ISG seems to have the default "energy management" tab. EMI customer do have an "alternative" energy management setting which reads: EMI on/off 😞

Screenshot 2024-02-13 at 13 32 47

@Padanian any news from HQ regarding the diffrent modbus documentations?

Padanian commented 9 months ago

@Padanian any news from HQ regarding the diffrent modbus documentations?

It would be great if you could clarify which one is correct.

German version is correct. English version is wrong and will be corrected in the next cycle of revision.

jaysus82 commented 8 months ago

Here, the status of the SG ready switches are still not shown correctly: image

ETS read: image

Input 2 should be on in HA. SG ready status is shown correctly as "1" (Input 1=0, Input 2=1),

Padanian commented 8 months ago

There's nothing wrong on this side. Possibly a wrong mapped register between canbus and modbus. I will notify the isg developers.

northalpha commented 8 months ago

While i like the discussion here around KNX enabled SG Ready states and non EMI enabled ISGs and so on but my initial issue / feature request i would like to point out is still not covered any i herby gently ask if @Padanian may check if there is an issue with EMI enabled ISGs, that the Register for SG Ready Operating State is not beeing changed or set or wrong register number to be read out or even not possible to get the information, because i can see that EMI kicks (at about 09:30 and 10:30) in and therefore should update the SG Ready Operating State to at least 3 or 4, see the graphs attached.

Screenshot 2024-03-07 at 11 09 21

Screenshot 2024-03-07 at 11 07 38

Screenshot 2024-03-07 at 11 07 51

Padanian commented 8 months ago

I'm aware of the issue and notified headquarter already days ago. I'm waiting for a check from them. I assume this is a bug in the ISG, but can't confirm at this time. Please bear with me in the meantime.

pail23 commented 5 months ago

@Padanian Are there any news from the headquater? How shall we proceed with this issue?

Padanian commented 5 months ago

No, but will follow up on them next week. Thx.

Padanian commented 5 months ago

Two bugs have been found in the ISG firmware in relation with SG ready. They are working on it. More info to come in the next couple of weeks.

northalpha commented 3 weeks ago

Heating season starts soon, so i took the opportunity to recheck on the status of the ISG Firmware bugfix again @Padanian ;)

Padanian commented 3 weeks ago

I notified the product owner again in Holzminden. He's currently off. I'll be back next week on this. @pail23 has been in contact with the guy, too. I don't know if there has been any advancement, unbeknownst to me.