Include GSS transaction code in libtr_tid and ensure the library is linkable when building - Githubissues

painless-security / trust-router

Moonshot Trust Router

0 stars 0 forks source link

Include GSS transaction code in libtr_tid and ensure the library is linkable when building #104

Closed jennifer-richards closed 6 years ago

jennifer-richards commented 6 years ago

This pull request resolves #102 by including tr_gss.c and tr_gss_client.c in the libtr_tid.la library sources. Without this, the library built but could not be linked against due to missing symbols.

To prevent accidental release of an unlinkable library in the future, this pull request also:

cleans up Makefile.am to make errors like this one less likely
builds a test program (tests/t_libtr_tid_la) against the library as part of make check
uses the libtr_tid.la library for trust_router, tidc, and tids binaries instead of duplicating the TID code

This also fixes #103, a bug that was discovered while testing the above.

jennifer-richards commented 6 years ago

Assigning to @meadmaker and @mrw42 for review - whoever has time.

I highly recommend setting the diff to ignore whitespace when examining the changes to Makefile.am