painless-security / trust-router

Moonshot Trust Router
0 stars 0 forks source link

Debian libtr_tid symbols file out of date and inaccurate #107

Open jennifer-richards opened 6 years ago

jennifer-richards commented 6 years ago

The debian/libtr_tid.symbols file is supposed to catalog information about the public symbols in the ABI for the shared library. This was created in 2014 and has not been updated since.

Ideally, this would involve examining the symbols that are exported and looking up the first version in which they appeared. It would probably be adequate to update it the current symbol list, attributing each to the current version.

Note that there is a function, tr_prefix_wildcard_match(), that was exported for convenience but which was not intended as part of the public interface. Exporting this is no longer necessary -- its use is now limited to the tr_constraint.c module, so it can become static. However, until the symbol list is sorted out, removing this interface results in errors building for Debian because it sees this is an interface removed from the ABI. It'd be nice to resolve this as well, but again, it may be ok simply to replace the symbols file.

Filing this as low priority wishlist becuase AFAIK, it is not causing any problems. It does not seem to be great package maintenance practice, though.