painless-security / trust-router

Moonshot Trust Router
0 stars 0 forks source link

Missing or incorrect information in monitoring responses #66

Closed jennifer-richards closed 6 years ago

jennifer-richards commented 6 years ago
jennifer-richards commented 6 years ago

The expiration time issue is addressed by 536646258cdf77d28015493c460022e6a239b4f3

jennifer-richards commented 6 years ago

Not currently seeing the connected to/from or last_connection issues. However, the TR clearly does not seem to be noticing when a peer disconnects.

jennifer-richards commented 6 years ago

I think all but the APCs for remote realms not being shown has been resolved.

jennifer-richards commented 6 years ago

The system currently copies the "apcs" list for a community update into the "apcs" list for a realm that is created as a result of the update. However, if the community itself was an APC, that list is empty. If the incoming community is an APC, any realms created by the update should be created with that community as its APC.

jennifer-richards commented 6 years ago

The last bit should be fixed by #74.

jennifer-richards commented 6 years ago

Test

Steps

  1. Set up a pair of trust routers as peers. Start them and let them establish their connections.
  2. Use trmon [...] show realms and verify that an APC is defined for every realm
  3. Use trmon [...] show communities and verify that the expiration times for remote realms appear as future UTC times
  4. Use trmon [...] show routes and verify that the expiration times for remote routes appear as future UTC times
  5. Use trmon [...] show peers and verify that each peer's connected_to, connected_from, and last_connection_attempt fields are accurate and that the latter is shown in a past UTC time

Expected results

As described in the steps above

meadmaker commented 6 years ago
  1. ✔️
  2. ✔️
  3. ✔️
  4. ✔️
  5. ✔️

Verified!